Improve handling of generic classes #12

New issue

Closed

opened 2022-12-21 15:25:23 +01:00 by Dutch · 1 comment

Dutch commented

2022-12-21 15:25:23 +01:00

Owner

Currently, this loop exists in the DaoExProcessor:

var entityClassType = classDeclaration.getAllSuperTypes()
                .first { t -> t.declaration.resolveName() == classNameRoomExDao }
                .arguments.first().type!!.resolve()

            // Todo: Handling of generic classes is not a great solution at this point. Should probably create a method to recursively traverse all superclasses and check all typearguments.
            while (entityClassType.isGeneric()) {

                // Now whe know that this type is generic, so we need to go the tree further up to check its actual base type
                entityClassType = classDeclaration.getAllSuperTypes()
                    .first { t -> t.declaration.toString() == entityClassType.declaration.parent.toString() }
                    .arguments.first().type!!.resolve()
            }

Just like the TODO comment suggests, this should be a helper function, probably an extension.

Currently, this loop exists in the DaoExProcessor: ```Kotlin var entityClassType = classDeclaration.getAllSuperTypes() .first { t -> t.declaration.resolveName() == classNameRoomExDao } .arguments.first().type!!.resolve() // Todo: Handling of generic classes is not a great solution at this point. Should probably create a method to recursively traverse all superclasses and check all typearguments. while (entityClassType.isGeneric()) { // Now whe know that this type is generic, so we need to go the tree further up to check its actual base type entityClassType = classDeclaration.getAllSuperTypes() .first { t -> t.declaration.toString() == entityClassType.declaration.parent.toString() } .arguments.first().type!!.resolve() } ``` Just like the `TODO` comment suggests, this should be a helper function, probably an extension.